Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path is not referenced properly #7

Closed
sauloco opened this issue Apr 15, 2021 · 2 comments
Closed

Path is not referenced properly #7

sauloco opened this issue Apr 15, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@sauloco
Copy link

sauloco commented Apr 15, 2021

https://github.com/lencx/vite-plugin-rsw/blob/bbd21056333116ec63c56b1db7a428eeb5278430/src/compiler.ts#L36

Looks like you could use path.sep or simply '/' when concatenating both directories names.

so it should say smt like: const crateRoot = root + '/' + rswCrate;

@lencx
Copy link
Member

lencx commented Apr 15, 2021

Thanks for the feedback. It's my negligence, it can be handled like this:

const crateRoot = path.resolve(root, rswCrate);

@lencx lencx added the bug Something isn't working label Apr 15, 2021
@sauloco
Copy link
Author

sauloco commented Apr 15, 2021

You're right. That's even better! thanks!

@lencx lencx closed this as completed in c80b5be Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants