Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLx, Diesel, etc RUSTSEC tracking issue. #2848

Closed
2 tasks
the10thWiz opened this issue Aug 18, 2024 · 2 comments
Closed
2 tasks

SQLx, Diesel, etc RUSTSEC tracking issue. #2848

the10thWiz opened this issue Aug 18, 2024 · 2 comments
Labels
upstream An unresolvable issue: an upstream dependency bug

Comments

@the10thWiz
Copy link
Collaborator

the10thWiz commented Aug 18, 2024

SQLx and Diesel have opened a RUSTSEC advisory for a bug in the binary transmission protocol. There is nothing we can directly do to help, beyond bumping our dependency versions once they have been merged.

During this process, I tried out the RUSTSEC auditing tool, and it looks like we also have two other potential issues, although as in this case, there is nothing we can do for now.

@the10thWiz the10thWiz added triage A bug report being investigated bug Deviation from the specification or expected behavior accepted An accepted request or suggestion upstream An unresolvable issue: an upstream dependency bug and removed triage A bug report being investigated accepted An accepted request or suggestion labels Aug 18, 2024
@SergioBenitez
Copy link
Member

SergioBenitez commented Aug 18, 2024

Rocket limits all user input by default. As such, there's no way to exhibit this issue without either passing very large input you create yourself, the negative effects of which you'd see directly, or using custom and exuberantly large >= 4GiB limits for input that flows into one of the affected sinks, which is extremely unlikely in general. Nevertheless, Rocket is doing something about this already, and as a general mechanism, it's all we can do. As such, I don't believe there's anything for us to track here as Rocket users are unaffected by default and extremely unlikely to be affected altogether.

@SergioBenitez SergioBenitez removed the bug Deviation from the specification or expected behavior label Aug 18, 2024
@SergioBenitez SergioBenitez closed this as not planned Won't fix, can't repro, duplicate, stale Aug 18, 2024
@the10thWiz
Copy link
Collaborator Author

I guess that's a fair assessment. Although I had seen that detail, I didn't make the connection to data limits. Raising the data limit to larger than 4GiB is likely enough to eliminate it as a DoS protection, so I think we can consider this a non-issue.

That being said, I think it's possible for a Rocket application to trigger this without changing the input limits (although it's extremely unlikely). I may have jumped the gun a bit, just because I saw that they went as far as opening a RUSTSEC advisory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream An unresolvable issue: an upstream dependency bug
Projects
None yet
Development

No branches or pull requests

2 participants