Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom traits is deprecated #29

Closed
adelarsq opened this issue Dec 23, 2016 · 5 comments
Closed

Custom traits is deprecated #29

adelarsq opened this issue Dec 23, 2016 · 5 comments
Labels
enhancement A minor feature request
Milestone
0.2.0

Comments

@adelarsq
Copy link

adelarsq commented Dec 23, 2016 •
edited
Loading

Running the forms example shows the following warning:

warning: `#[derive]` for custom traits is deprecated and will be removed in v1.15. Prefer using procedural macro custom derive
  --> src\main.rs:12:10
   |
12 | #[derive(FromForm)]
   |          ^^^^^^^^
@SergioBenitez
Copy link
Member

The warning will go away as soon as Rust releases a new nightly. Waiting for rust-lang/rust#38533.

@SergioBenitez SergioBenitez added the enhancement A minor feature request label Dec 23, 2016
@SergioBenitez SergioBenitez added this to the 0.2.0 milestone Dec 23, 2016
@ishitatsuyuki
Copy link

There's always a reason to warn you. Have you considered to step a bit back from relying on plugin, and use the stabilized macros?

@SergioBenitez
Copy link
Member

@ishitatsuyuki Of course! Please see #50 and the linked comment for my thoughts.

@SergioBenitez
Copy link
Member

Fixed in 337173e.

@zoumi
Copy link

zoumi commented Sep 4, 2017

I got this warn.
My rust version:

Default host: x86_64-pc-windows-gnu

nightly-i686-pc-windows-gnu (default)
rustc 1.21.0-nightly (f774bced5 2017-08-12)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement A minor feature request
Projects
None yet
Milestone
0.2.0
Development

No branches or pull requests
4 participants
@adelarsq @SergioBenitez @zoumi @ishitatsuyuki