-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emitted items should be pub only if the request handler is pub. #93
Comments
One concern is that this makes testing more difficult as you'll now need to |
Let's push this to 0.3 as it's not critical. |
I struggle to weigh the benefits (private by default) against the cons (usability implications). Any input that might provide justification for or against this change would be beneficial. |
I'm neither for or against this change as it doesn't impact me in the slightest. I favor a large (and separate) integration suite so pub/no-pub doesn't really affect my testing. |
Generally, I see this as a consistency issue: if something is not declared public, it should not secretly become public. Namely, I think you should allow people to export a single function from a file which returns a vector of routes, while keeping those functions private. As a side note, I feel like this relates to #174, in that it's only an issue if people are breaking things up across multiple files, e.g. in sufficiently large projects. This seems like an OCD thing, and I don't think it's the end of the world if the functions are re-exported publicly. |
No description provided.
The text was updated successfully, but these errors were encountered: