Did not get error that my relative path was not starting with node_modules

[melvinroest]

My path was vendor/edited/bugout/index.js. It took me a long time to figure out what went wrong, until I read the source of this library since I was guessing it reads out the node_modules folder. I did not get the error: The "cjs" transform works only with NPM packages.
You tried to use it with "${relativePath}". Make sure your imported file path
begins with "node_modules/".

This is my full output of the command ember serve --port 4444

Could not start watchman
Visit https://ember-cli.com/user-guide/#watchman for more info.
Cannot find module '.js' from '/Users/username/path_to_app'


Stack Trace and Error Report: /var/folders/_4/xkxbjb2x1173s0mpwmxcqkkh0000gn/T/error.dump.e7c384ff0fbccc21ee4b04b0ced69e44.log

The stack trace and error report also didn't show it.

[nathankellenicki]

We also ran into this issue. My guess is that the throw is captured higher up and a more generic "Cannot find module" error is spat out.

The bigger issue is though, that we are doing the same as you - vendoring our dependencies inside a vendor/ directory, which this addon explicitly can't support.

[GavinJoyce]

The "cjs" transform works only with NPM packages.
You tried to use it with "${relativePath}". Make sure your imported file path
begins with "node_modules/".

Is there a technical reason why the file being transformed needs to be in node_modules? I have a build time AST transform (in common js), which I also want to use at runtime in an ember app (a code playground type app), and I'm struggling to find a way of reusing this file other than extracting to a separate package

[rwjblue]

@GavinJoyce - Largely due to the way we cache. It would be possible to remove the requirement that it start with node_modules, but would take a bit more care to get the caching bits right.

[allinne]

Are there any news? I ran into this issue also.

[rwjblue]

Nope, doesn't seem like anyone has had a chance to dig into what is going on.

[noyesa]

I just ran into this as well. I wasn't aware this doesn't support non-NPM modules and ran into the problem with the slice on the file path here:

ember-cli-cjs-transform/src/cjs-transform.js

Line 60 in eb50b99

let fullPath = resolveSync(relativePath.slice(NODE_MODULES.length), {

It seems calculateCacheKey gets called before the node_modules validation happens in processFile.