[Major]: Remove Moment and Node 10 #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snewcomer
force-pushed
the
sn/rm-moment-major
branch
from
618aa81
to
34ae39b
Compare
snewcomer
force-pushed
the
sn/rm-moment-major
branch
from
34ae39b
to
6fbbbb5
Compare
snewcomer
force-pushed
the
sn/rm-moment-major
branch
from
7fa7260
to
f3fc385
Compare
snewcomer
force-pushed
the
sn/rm-moment-major
branch
from
5d56e54
to
1d22eda
Compare
snewcomer
changed the title
snewcomer
force-pushed
the
sn/rm-moment-major
branch
from
bf23b5a
to
f7cf8b0
Compare
This was referenced Jul 20, 2021
Update to ember-validates v4 is breaking change
adopted-ember-addons/ember-changeset-validations#314
Open
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #69
Considerations
Dates can be compared either with
getTimeor if in string format, we can compare "11/2/2014 < "11/3/2014".precisionargument. If you need to compare based on precision, you can use the Intl.DateTimeFormat APIs to hone in on the comparison -{ year: 'numeric' }. Even{ dateStyle: 'full' }works!en-uswhen creating date times. This is probably less useful for the actual on/before/after but it can help in formatting your error message.Some other options
In any case this will require a change in the
formatargument.e.g. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/DateTimeFormat/format