make package_json required to some APIs

Author: ryanatkn

.changeset/happy-parrots-check.md

@@ -0,0 +1,5 @@
+---
+'@ryanatkn/gro': minor
+---
+
+make `package_json` required to some APIs

src/lib/gro.config.default.ts

@@ -5,6 +5,7 @@ import {gro_plugin_sveltekit_app} from './gro_plugin_sveltekit_app.js';
 import {has_sveltekit_app, has_sveltekit_library} from './sveltekit_helpers.js';
 import {gro_plugin_gen} from './gro_plugin_gen.js';
 import {gro_plugin_moss, has_moss_dep} from './gro_plugin_moss.js';
+import {load_package_json} from './package_json.js';
 
 /**
  * This is the default config that's passed to `gro.config.ts`
@@ -16,15 +17,17 @@ import {gro_plugin_moss, has_moss_dep} from './gro_plugin_moss.js';
  * - if `src/lib/server/server.ts`, assumes a Node server
  */
 const config: Create_Gro_Config = async (cfg) => {
+	const package_json = load_package_json(); // TODO gets wastefully loaded by some plugins, maybe put in plugin/task context? how does that interact with `map_package_json`?
+
 	const [
 		moss_plugin_result,
 		has_server_result,
 		has_sveltekit_library_result,
 		has_sveltekit_app_result,
 	] = await Promise.all([
-		has_moss_dep(),
+		has_moss_dep(package_json),
 		has_server(),
-		has_sveltekit_library(),
+		has_sveltekit_library(package_json),
 		has_sveltekit_app(),
 	]);
 

src/lib/gro_plugin_moss.ts

@@ -16,7 +16,7 @@ import {has_dep, type Package_Json} from './package_json.js';
 export const MOSS_PACKAGE_DEP_NAME = '@ryanatkn/moss';
 
 export const has_moss_dep = (
-	package_json?: Package_Json,
+	package_json: Package_Json,
 	dep_name = MOSS_PACKAGE_DEP_NAME,
 ): Result<object, {message: string}> => {
 	if (!has_dep(dep_name, package_json)) {

src/lib/gro_plugin_sveltekit_library.ts

@@ -26,16 +26,22 @@ export const gro_plugin_sveltekit_library = ({
 	svelte_package_options,
 	svelte_package_cli = SVELTE_PACKAGE_CLI,
 }: Gro_Plugin_Sveltekit_Library_Options = {}): Plugin => {
+	const package_json = load_package_json();
+
 	return {
 		name: 'gro_plugin_sveltekit_library',
 		setup: async ({dev, log, config}) => {
 			if (!dev) {
-				await run_svelte_package(svelte_package_options, svelte_package_cli, log, config.pm_cli);
+				await run_svelte_package(
+					package_json,
+					svelte_package_options,
+					svelte_package_cli,
+					log,
+					config.pm_cli,
+				);
 			}
 		},
 		adapt: async ({log, timings, config}) => {
-			const package_json = load_package_json();
-
 			// link the CLI binaries if they exist
 			if (package_json.bin) {
 				const timing_to_link = timings.start(`${config.pm_cli} link`);

src/lib/publish.task.ts

@@ -67,7 +67,9 @@ export const task: Task<Args> = {
 			log.info(st('green', 'dry run!'));
 		}
 
-		const has_sveltekit_library_result = has_sveltekit_library();
+		const package_json = load_package_json();
+
+		const has_sveltekit_library_result = has_sveltekit_library(package_json);
 		if (!has_sveltekit_library_result.ok) {
 			throw new Task_Error(
 				'Failed to find SvelteKit library: ' + has_sveltekit_library_result.message,
@@ -109,11 +111,10 @@ export const task: Task<Args> = {
 		if (dry) {
 			log.info('dry run, skipping changeset version');
 		} else {
-			const package_json_before = load_package_json();
-			if (typeof package_json_before.version !== 'string') {
+			if (typeof package_json.version !== 'string') {
 				throw new Task_Error('Failed to find package.json version');
 			}
-			const parsed_repo_url = parse_repo_url(package_json_before);
+			const parsed_repo_url = parse_repo_url(package_json);
 			if (!parsed_repo_url) {
 				throw new Task_Error(
 					'package.json `repository` must contain a repo url (and GitHub only for now, sorry),' +
@@ -139,9 +140,9 @@ export const task: Task<Args> = {
 				await update_changelog(parsed_repo_url.owner, parsed_repo_url.repo, changelog, token, log);
 			}
 
-			const package_json_after = load_package_json();
-			version = package_json_after.version!;
-			if (package_json_before.version === version) {
+			const package_json_after_versioning = load_package_json();
+			version = package_json_after_versioning.version!;
+			if (package_json.version === version) {
 				// The version didn't change.
 				// For now this is the best detection we have for a no-op `changeset version`.
 				if (optional) {

src/lib/release.task.ts

@@ -2,6 +2,7 @@ import {z} from 'zod';
 
 import type {Task} from './task.js';
 import {has_sveltekit_library, has_sveltekit_app} from './sveltekit_helpers.js';
+import {load_package_json} from './package_json.js';
 
 export const Args = z.object({}).strict();
 export type Args = z.infer<typeof Args>;
@@ -10,7 +11,9 @@ export const task: Task<Args> = {
 	summary: 'publish and deploy',
 	Args,
 	run: async ({invoke_task}) => {
-		const publish = has_sveltekit_library().ok;
+		const package_json = load_package_json();
+
+		const publish = has_sveltekit_library(package_json).ok;
 		if (publish) {
 			await invoke_task('publish', {optional: true});
 		}

src/lib/sveltekit_helpers.ts

@@ -30,7 +30,7 @@ export const has_sveltekit_app = (): Result<object, {message: string}> => {
 };
 
 export const has_sveltekit_library = (
-	package_json?: Package_Json,
+	package_json: Package_Json,
 	sveltekit_config: Parsed_Sveltekit_Config = default_sveltekit_config,
 	dep_name = SVELTE_PACKAGE_DEP_NAME,
 ): Result<object, {message: string}> => {
@@ -149,12 +149,13 @@ export interface Svelte_Package_Options {
 }
 
 export const run_svelte_package = async (
+	package_json: Package_Json,
 	options: Svelte_Package_Options | undefined,
 	cli: string | Cli,
 	log: Logger,
 	pm_cli: string,
 ): Promise<void> => {
-	const has_sveltekit_library_result = has_sveltekit_library();
+	const has_sveltekit_library_result = has_sveltekit_library(package_json);
 	if (!has_sveltekit_library_result.ok) {
 		throw new Task_Error(
 			'Failed to find SvelteKit library: ' + has_sveltekit_library_result.message,