Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plan to update node-sass to 4.x? #34

Open
youluna opened this issue Oct 22, 2018 · 1 comment
Open

Any plan to update node-sass to 4.x? #34

youluna opened this issue Oct 22, 2018 · 1 comment

Comments

@youluna
Copy link

youluna commented Oct 22, 2018

Sassaby is one of my project's devDependencies. I'm using node@8.x. When running npm install, I can always see c++ files not found as follows:
../src/sass_types/list.cpp:28:19: error: no matching function for call to 'sass_make_list'

As sass/node-sass#2012 says, node-sass added support for node 8 in 4.5.3.
But sassaby use node-sass@3.x. Do you have any plan to update the devDependency node-sass to 4.x ?

@youluna
Copy link
Author

youluna commented Oct 29, 2018

I forked this project, and upgrade node-sass to 4.x. My project's works well with new sassaby. However I can't make all test cases of sassaby pass , there is always one test failed.

So I will not creat PR, but release a new package named sassaby-next instead, just for my use. If you don't want me to do that, comment the issue to let me know and I will stop sassaby-next.

Thank you for awsome tool ! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant