Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error thrown when updating #151

Open
Oted opened this issue Mar 18, 2016 · 2 comments · May be fixed by #185
Open

Error thrown when updating #151

Oted opened this issue Mar 18, 2016 · 2 comments · May be fixed by #185

Comments

@Oted
Copy link

Oted commented Mar 18, 2016

Hi!

So it seems like when doing an update with an invalid date value, the update causes vogels to throw an error with the following stack trace

RangeError: Invalid time value at Date.toISOString (native) at Object.internals.serialize.date
(/var/task/node_modules/cattle/node_modules/vogels/lib/serializer.js:35:30) at
Object.internals.serializeAttribute.serializer.serializeAttribute

It seems to me like the error should come back in the update callback instead of throwing an error.
@justinmchase
Copy link

Sounds like an easy pull request 😄

This was referenced Aug 12, 2016
Closed
Open
@clarkie clarkie mentioned this issue Aug 14, 2016
Merged
@clarkie
Copy link

clarkie commented Aug 14, 2016

I've fixed this over in Dynogels: clarkie/dynogels#15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle thrown errors during updateExpressions FenrirUnbound/vogels
3 participants
@justinmchase @clarkie @Oted