Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Speed rate to Audio Service #259

Closed
mohammadne opened this issue Apr 11, 2020 · 5 comments
Closed

Add Speed rate to Audio Service #259

mohammadne opened this issue Apr 11, 2020 · 5 comments
Assignees
Labels
1 backlog enhancement New feature or request

Comments

@mohammadne
Copy link

add a method to set the speed rate and a getter to get speed rate

@ryanheise ryanheise self-assigned this Apr 11, 2020
@ryanheise
Copy link
Owner

As mentioned in earlier issues, the set of methods is defined by the underlying Android MediaSession and related APIs to define a standard protocol understood by compatible peripheral devices. You can add additional non-standard methods via customAction.

There is already a getter for the speed rate in class PlaybackState.

@mohammadne
Copy link
Author

As you define a method to set speed rate in just_audio, I think this is good to be implemented in audio_service

@ryanheise
Copy link
Owner

audio_service is not based on just_audio but rather is based on MediaController.TransportControls. Based on this API, setting speed would be done through a custom action.

I will leave this issue open, however, as I do think there is room to add a small number of exceptions to the rule. setSpeed could be one of those, and setQueue could be another.

@ryanheise
Copy link
Owner

This is now added in the latest release.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs, or use StackOverflow if you need help with audio_service.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 backlog enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants