Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support BasicPlaybackState.completed #306

Closed
itog opened this issue May 8, 2020 · 6 comments
Closed

Support BasicPlaybackState.completed #306

itog opened this issue May 8, 2020 · 6 comments
Assignees
Labels
1 backlog enhancement New feature or request

Comments

@itog
Copy link
Contributor

itog commented May 8, 2020

In some cases, I need to know if the audio was completed or skipped.

I could do it with CustomEvent, but I think the most simple way to do it is support BasicPlaybackState.completed

@itog itog added 1 backlog enhancement New feature or request labels May 8, 2020
@ryanheise
Copy link
Owner

The main consideration is that these states follow a standard protocol that is understood by peripheral media devices like Android Auto, etc. and this comes with a standard set of states, and completed is not in that standard enum. Do you have a proposal for how to address with this consideration?

@itog
Copy link
Contributor Author

itog commented May 11, 2020

As you mentioned, 'completed' is not included in PlaybackState in Android and I found 'finished' status in 'MediaItemStatus' class.
https://developer.android.com/reference/androidx/mediarouter/media/MediaItemStatus

To follow the standard, it looks better to change currentMediaItemStream to something like 'itemStatusStream ' even it requires more work.

@ryanheise
Copy link
Owner

What you're linking to is a different standard for routing audio (e.g. to a Chromecast). audio_service instead uses this:

https://developer.android.com/guide/topics/media-apps/working-with-a-media-session

@itog
Copy link
Contributor Author

itog commented May 12, 2020

I see.

I will consider to realize my use case with CustomEvent or other.
Thank you for your help!

@ryanheise
Copy link
Owner

No worries!

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs, or use StackOverflow if you need help with audio_service.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 backlog enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants