Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShureTechMono "fi" text overlap. #1631

Closed
Markov-Komarov opened this issue May 8, 2024 · 11 comments
Closed

ShureTechMono "fi" text overlap. #1631

Markov-Komarov opened this issue May 8, 2024 · 11 comments

Comments

@Markov-Komarov
Copy link

🗹 Requirements

-🗹 I have searched the issues for my issue and found nothing related and/or helpful
-🗹 I have searched the FAQ for help
-🗹 I have searched the Wiki for help

🎯 Subject of the issue

Experienced behavior:

st terminal firefox and pcmanfm-gkt3 show overlapping text when displaying "fi" followed by any letter. Similar to #784

Expected behavior:

writing the word "config" or "find" " displays the word with no overlap between "i" and the following letter.

Example symbols:

no symbol. text "fi"+any letter.

🔧 Your Setup

  • Which font are you using ?
    • ShureTechMono Nerd Font
  • Where did you get the file from (download link, self patched, source downloaded from link...)
    • pacman (ttf-sharetech-mono-nerd 3.2.1-1 package) Also tried direct download from this repo.
  • Which terminal emulator are you using (e.g. iterm2, urxvt, gnome, konsole)?
    • st terminal 0.9.2 patched enough to properly show nerd fonts (confirmed with Terminess and CaskaydiaCove)
  • Are you using OS X, Linux or Windows? And which specific version or distribution?
    • Arch Linux 6.8.9

★ Screenshots (Optional)

st with Terminess

05-08-2024-03-25-03
st with ShureTech
05-08-2024-03-27-52

The issue is resolved in gtk apps setting the font type to propo
05-08-2024-03-28-58

unfortunately st even when specifying propo font type it continues to show overlaping text
05-08-2024-03-33-13
I would blame it on my poor C knowledge (like missconfiguring st) but when using CaskaydiaCove or Terminess fonts there is no overlapping
05-08-2024-03-36-11

@Finii
Copy link
Collaborator

Finii commented May 8, 2024

Waaah!!! 😱

Sorry to hear this, thanks for reporting. Investigating immediately.

@Finii
Copy link
Collaborator

Finii commented May 8, 2024

I guess you use the Nerd Font Mono variant?

image

@Finii
Copy link
Collaborator

Finii commented May 8, 2024

Fixed it via special rule.

a) Was my impression right that you use the Nerd Font Mono?
b) Would you like fixed version here in a comment or is next release (whenever that will be) soon enough?

image

@Finii
Copy link
Collaborator

Finii commented May 8, 2024

@allcontributors please add @Markov-Komarov for bug

Copy link
Contributor

@Finii

I've put up a pull request to add @Markov-Komarov! 🎉

@Finii
Copy link
Collaborator

Finii commented May 8, 2024

Ah, I could not see the original error with writer, but scribus could of course show it. Just for future reference if someone wants to reproduce the error/fix.

@Finii
Copy link
Collaborator

Finii commented May 8, 2024

Fixed via 3043085

@Finii Finii closed this as completed May 8, 2024
@Finii
Copy link
Collaborator

Finii commented May 8, 2024

Nerd Fonts Patcher v3.2.1-37 (4.14.3) (ff 20230101)
INFO: Adding config commandline options: --removeligatures
DEBUG: Naming mode 1
DEBUG: Monospace check: Panose says "monospaced"; glyph-width-mono True
INFO: Removing ligatures from configfile `Subtables` section
DEBUG: Removing subtable: 'liga' Standard Ligatures lookup 5 subtable
DEBUG: Successfully removed subtable: 'liga' Standard Ligatures lookup 5 subtable
DEBUG: Removing subtable: 'dlig' Discretionary Ligatures lookup 4 subtable
DEBUG: Successfully removed subtable: 'dlig' Discretionary Ligatures lookup 4 subtable
DEBUG: Final font cell dimensions 540 w x 1127 h
Done with Patch Sets, generating font...
DEBUG: Weight approximations: OS2/PS/Name: 400/400/400 (from 400/'Book'/'')
DEBUG: =====> Family (ID 1)      ok       (23 <=31): ShureTechMono Nerd Font
DEBUG: =====> SubFamily (ID 2)   ok       ( 7 <=31): Regular
DEBUG: =====> Fullname (ID 4)    ok       (23 <=63): ShureTechMono Nerd Font
DEBUG: =====> PSN (ID 6)         ok       (15 <=63): ShureTechMonoNF
DEBUG: Tweaking 1/1
DEBUG: Changing flags from 0x1F to 0x17
DEBUG: Changing lowestRecPPEM from 8 to 7
   ShureTechMono Nerd Font
   \===> '/home/fini/extra/git/nerd-fonts/patched-fonts/ShareTechMono/ShureTechMonoNerdFont-Regular.ttf'

As there is no real plan when the next Nerd Fonts release will be, please find the fixed fonts attached:

ShareTechMono.zip 3.4MB

@Finii Finii added this to the v3.3.0 milestone May 8, 2024
@Finii
Copy link
Collaborator

Finii commented May 8, 2024

unfortunately st even when specifying propo font type it continues to show overlaping text

The font itself is ok, but that is some kind of compromise that st does on its end. It does allow ligatures but expects them to not-change the character width. That is not true in general, just a lot of terminal fonts do it that way (keep the advance width constant) for various reasons, not the least being that is is hard(er) to work with the classical ligatures.
For that reason Nerd Fonts generally removes the two-letter ligatures because in programming contexts they are almost always unwanted and are just there because 'fonts do have fi ligatures' from a typographer's perspective ;)

@Markov-Komarov
Copy link
Author

05-08-2024-11-33-03
Thank you so much for the clarification and the fix itself :DD

Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants