Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update fira code to latest #649

Closed
jiyometrik opened this issue Aug 8, 2021 · 7 comments
Closed

update fira code to latest #649

jiyometrik opened this issue Aug 8, 2021 · 7 comments
Milestone

Comments

@jiyometrik
Copy link

jiyometrik commented Aug 8, 2021

Add Ligatures to Fira Code

Some of the ligatures offered in the original Fira Code are not included in the Nerd Font version, including but not limited to:

  • infinites (-------- and ==========)
  • arrows (|=====|, ==>>, etc.)

Edit: this also applies to other fonts, such as JetBrains Mono and Caskaydia Cove (NF version of Cascadia Code)

🔧 Your Setup

  • Which font are you using (e.g. Anonymice Powerline Nerd Font Complete.ttf)?
    Fira Code Regular Nerd Font Complete Windows Compatible
  • Which terminal emulator are you using (e.g. iterm2, urxvt, gnome, konsole)?
    Windows Terminal
  • Are you using OS X, Linux or Windows? And which specific version or distribution?
    Ubuntu 20.04 on Windows Terminal

★ Comparison Screenshots

Original
image

Nerd Font
image

@awilkins
Copy link

Fira Code has now (April 2020) disabled the horrible traditional ligatures like Fl since version 3.0 ; current release is 5.2, Nerd Font version is back at version 2.

Arrows got a major overhaul in version 4 and this may be the basis of your issue.

@HudsonMC16
Copy link

You ever figure anything else out here? This issue is in each font I want to use, apparently, and it looks like I'm running an identical setup. Is this only a Windows issue?

@jiyometrik
Copy link
Author

no @HudsonMC16, i think the issue is with the version of the font that is being patched. the original fonts have all been updated since the time of patching, so the version of the font being used in this repo is outdated.

@ryanoasis ryanoasis changed the title patch ligatures in fira code update fira code to latest Dec 14, 2021
@ryanoasis
Copy link
Owner

@g-e-o-m-e-t-r-i-c I've updated the title of the issue. Thanks for follow up

@Finii
Copy link
Collaborator

Finii commented Jan 15, 2023

@Finii Finii added this to the v2.3.0 milestone Jan 15, 2023
@Finii
Copy link
Collaborator

Finii commented Jan 15, 2023

This has already been updated with commit
78be0e1 Add unpatched FiraCode v6.2

@Finii Finii closed this as completed Jan 15, 2023
@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants