Victor Mono Complete - Italic/oblique variants seen as "duplicate" in MacOS #663
Comments
McAllaster
changed the title
|
Can confirm have seen this for NerdFont Firacode and all it's variants on MacOS! |
|
Lets see which fonts we have here and how they are named.
😒 There are two solutions:
Here is how it is handled by the original font (they choose option 1)
The font-patcher renaming stuff is obviously not so good when whole suites of fonts are patched. This might need more thinking first. Btw, I'm on Linux but with the given data not only Mac is affected but also Win and Linux, although they do not warn 😬 |
|
Already set up some helper scripts to analyze the situation across all fonts in |
|
This is what the renaming results in (one example):
Note that we get this warning when opening... * = A PostScript name should be ASCII and must not contain Here's my 'debug-patch': https://gist.github.com/Finii/a496cff7eb38933b169110be3e4e8af2 Edit: Add gist of debugging changes |
|
Lets examine how some other fonts with lots of weights handle that.
Thus each weight is identified on it's own, with vertical and slanted grouped into one. Here is the same table for Victor, SFNT Full and SFNT PSName removed (see above): |
|
As visual person I needed to draw lines how (Note: Where the images refer to the filename the PS Fontname is really used)
There are 4 things to be named:
FullnameTakes the source font PS fullname, and appends a verbose suffix (generated with "Nerd Font" and the options we specified while patching like Mono, Complete, ...). FamilynameTakes the base part of the PS fontname (in the code: SubFamilyIf the source font does contain a subfamily and it is not "Regular" we start with that. FontnameWe start with the PS fontname part (all before the first Thats all the glory... and the problems. I believe there has been a misunderstanding what needs to be in the SubFamily and in the Familyname, and that is what causes the problems we have with fonts that have a lot of weights. Lets see if we can do better. Edit: Correct misread |
|
Researched this a bit more (as usual this talking-to-myself comments are to document reasons for commits) There are two Font Grouping ways...
Both grouping methods should be supported in parallel. For these we have 4 SFNT fields:
This is taken from MS. So just concentrating on SFNT and Victor Mono, we have: The ID1/2 grouping is broken (as I already mentioned above), but also the ID16/17 grouping is strange and can not be used (without ID1/2 in parallel), and that is obviously what MacOS finds. |
|
This is how I would expect the naming to be, ignoring the Oblique that complicates everything here: |
|
This is how the unpatched Victor is grouped: Note that a missing field in 16/17 automagically uses 1/2 instead. Edit: Include Oblique |
|
This is solved if you/we patch with At the moment we test that only on a few fonts but I expect with |
|
Release is in repo, release as packages pending. |
|
This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference. |
🎯 Subject of the issue
Originally posted by @mbirth in #494 (comment)
Looks like a similar issue to #257 to me. Possibly related to #494, but I assume they are different enough to warrant their own issues.
🔧 Your Setup
★ Optional
The text was updated successfully, but these errors were encountered: