Vertical alignment wrong?

[Finii]

Discussed in #874

^{Originally posted by augustocdias August 10, 2022}
I'm trying to patch codicons into Firacode and I'm having some issues. It is adding a bottom padding to the glyphs.

Is there a flag or a setting I can set to adjust this and fix it?

This is how I patched it:

fontforge -script font-patcher  /Users/augusto/Library/Fonts/Fira\ Code\ Retina\ Nerd\ Font\ Complete\ Mono.otf --custom codicon.ttf 

I installed the font from brew.

---

Additional info:

Can be reproduced with current master font-patcher, using v2.1.0 Fira Code NF and https://github.com/microsoft/vscode-codicons/blob/main/dist/codicon.ttf

[Finii]

Hmm, this is 'as intended':

There is no scaling for '--custom' and no valign.

And this is the case since ... the invention of --custom

So this might be unexpected, but someone choose it this way specifically.
Of course we could discuss to change it, but for now I see no need.

[github-actions]

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.