Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recording indication #179

Closed
ryonakano opened this issue Oct 19, 2022 · 4 comments · Fixed by #193 or #198
Closed

Add recording indication #179

ryonakano opened this issue Oct 19, 2022 · 4 comments · Fixed by #193 or #198

Comments

@ryonakano
Copy link
Owner

Originally from #175 (comment):

If I can just pick your brain for a quick feature request, it would be nice to have some sort of indication of signal, maybe just a little red light when there is speech, something... because I just made a recording without my microphone plugged in and didn't even notice until I saw the file size :)

@nekohayo
Copy link

nekohayo commented Nov 3, 2022

Perhaps you could take inspiration from the gnome-sound-recorder's realtime waveform visualization implementation?

@nekohayo
Copy link

nekohayo commented Nov 3, 2022

Other alternatives include:

  • Using GtkProgressbar or GtkLevelbar to indicate volume of the microphone, system, or both. This is what PulseCaster does.
  • Imitating Pitivi's new vumeter widget implementation

@ryonakano
Copy link
Owner Author

Yeah, it would be ideal to make something similar to the indication seen in GNOME Sound Recorder; showing waves would be common in this situation.

@nekohayo
Copy link

nekohayo commented Nov 4, 2022

The only thing is, I'm not entirely sure (yet) if the waves "as implemented in g-s-r" are the ones causing this CPU-eating performance issue on startup, but since your application is simpler and not trying to list all previous recordings, only show a live waveform while it's happening, then you will probably not have the same problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants