Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ViomiVacuumState 6 seems to be VaccuumMopping #783

Closed
fs79 opened this issue Aug 3, 2020 · 3 comments · Fixed by #784
Closed

ViomiVacuumState 6 seems to be VaccuumMopping #783

fs79 opened this issue Aug 3, 2020 · 3 comments · Fixed by #784

Comments

@fs79
Copy link
Contributor

fs79 commented Aug 3, 2020

Is your feature request related to a problem? Please describe.
When the vacuum is in mop and vacuum mode it states State 6.
So, please add state 6. Feel free to choose a name which follows your naming convention.

Please add state 6 to viomivacuum.py


VacuumMopping = 6

  • Model: Xiaomi Mi Robot Vacuum-Mop P
  • Hardware version: STYTJ02YM
  • Firmware version: 3.5.3_0017
@rytilahti
Copy link
Owner

Fixed, thanks for reporting! 🎉

@fs79
Copy link
Contributor Author

fs79 commented Aug 3, 2020

Hi,
mode 6 is vaccuming and mopping.
There´s a mop only mode which I can´t test because I have no water only tank so maybe its better to call this mode not "mopping" but something which is mopping and vacuuming.

Thanks for being so fast with getting the change included.

@rytilahti
Copy link
Owner

Hi, thanks for the info! I really shouldn't have merged that so quickly.. :-)

I just created a new PR to rename this mode, the good thing is that the previous PR also added a warning message when the status is unknown, so maybe someone at some point will report back when they encounter that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants