Skip to content
This repository has been archived by the owner on Dec 1, 2019. It is now read-only.

webpack-dev-server live-reload and error overlay does not work with 3.0.2 but did in 3.0.0-beta.14 #365

Closed
jonaskello opened this issue Feb 5, 2017 · 3 comments

Comments

@jonaskello
Copy link

I upgraded today from 3.0.0-beta.14 to 3.0.2 and noticed that the overlay feature in webpack-dev-server stopped working. Not sure why, I'm guessing it has something to do with webpack-dev-server not being able to determine that atl fails. I'm using webpack 2.2.1 and webpack-dev-server 2.3.0. Let me know if example code to repro the issue is needed.

@jonaskello
Copy link
Author

Another related observation is that with live-reload enabled in webpack-dev-server it will now reload even when atl fails with errors. In beta14 it would not reload but just report the errors in the console. Probably the root cause is the same as for the error overlay not working.

@jonaskello jonaskello changed the title webpack-dev-server overlay does not work with 3.0.2 but did in 3.0.0-beta.14 webpack-dev-server live-reload and error overlay does not work with 3.0.2 but did in 3.0.0-beta.14 Feb 5, 2017
@s-panferov
Copy link
Owner

s-panferov commented Feb 6, 2017

@jonaskello the main reason of this behavior is that error reporting is async in the 3x version. "async" means that webpack don't wait for the atl to mark build VALID and make HMR. It speeds up development print-eval cycle.

You can work-around this behavior by disabling CheckerPlugin or make the loader silent

@jonaskello
Copy link
Author

Aha, that makes sense now. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants