Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V5 - Typescript: thousand isn't accepted by the thousandsGroupStyle prop #679

Closed
Treycos opened this issue Sep 30, 2022 · 1 comment
Closed

V5 - Typescript: thousand isn't accepted by the thousandsGroupStyle prop #679

Treycos opened this issue Sep 30, 2022 · 1 comment

Comments

@Treycos
Copy link

Treycos commented Sep 30, 2022

The thousandsGroupStyle prop's typescript interface doesn't seem to recognise the thousand value while being available in the documentation (thousand)

TS Error:

Type '"thousand"' is not assignable to type '"none" | "lakh" | "wan" | undefined'.ts(2322)

types.d.ts(69, 5): The expected type comes from property 'thousandsGroupStyle' which is declared here on type 'IntrinsicAttributes & InternalNumberFormatBase & { thousandSeparator?: string | boolean | undefined; decimalSeparator?: string | undefined; ... 7 more ...; prefix?: string | undefined; } & Omit<...> & Omit<...> & { ...; }'
@louismariegaborit louismariegaborit mentioned this issue Sep 30, 2022
Merged
@s-yadav
Copy link
Owner

s-yadav commented Oct 1, 2022

fixed on v5.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@s-yadav @nikhil-varma @Treycos