Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard Shortcuts not working (VSCode usage issues) #2

Open
jonnyhotchkiss opened this issue Dec 4, 2023 · 2 comments
Open

Keyboard Shortcuts not working (VSCode usage issues) #2

jonnyhotchkiss opened this issue Dec 4, 2023 · 2 comments

Comments

@jonnyhotchkiss
Copy link

Hi, this is a vscode noob question on windows keyboard shortcuts, and using the sonicpi extension shortcuts (currently any keypress is sent to menu bar)

I see the Keyboard Shortcuts like Alt+R to run either SonicPi or the focussed cell (in edit more or select mode, in .pibook)

I've just tried setting menu to hidden (vscode settings) as recommended here but still unable to use commands. Should I adjust the mnemonic setting also?

Even when I do this, the menu no longer appears, but also no sound made (selected cell in welcome.pibook and tried to run with alt+t and alt+r , only works with either (notebook default?) ctrl+alt+enter (and alt+s to stop thankfully works!) or via the command palette...

Am assuming there's a few parts to this - understanding the various where clauses (and best practices to make hotkeys call commands
Alternatively I could avoid clashing configs (not preferred), or maybe "rename" the items on menu bar ..

Any tips welcome!

@iamjonny
Copy link

iamjonny commented Dec 5, 2023

Update: playing with code lots, currently on a portable build using a sonic-pi profile. The alt+t works in .pi

I see *Run Notebook Cell is mapped with "editorLangId == 'sonic-pi' && notebookType == 'sonic-pi-book'" but when testing (created new sonic pi notebook, focus on sample code cell with pentatonic bleeps) alt+r calls run, and when inside the cell alt+r does nothing, and the alt+t calls the Terminal menu.

Checking alt+t I see the reason for the latter is the condition that the notebook type isn't sonic-pi-book, which also answers my question of what type a .pibook file is... but still unable to use the intended alt+r.

Not sure what gives!
image

@iamjonny
Copy link

iamjonny commented Dec 5, 2023

I got round the kb issues by adjusting the clauses, perhaps these clash with other user's common shortcuts, but here they just block the shortcuts from working.

Run alt+r when editorLangId == 'sonic-pi'
Run notebook cell alt+r when notebookType == 'sonic-pi-book'
Run selected alt+t when editorLangId == 'sonic-pi'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants