Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New CVar: mp_plant_c4_anywhere #692

Merged
merged 7 commits into from
Oct 28, 2021
Merged

New CVar: mp_plant_c4_anywhere #692

merged 7 commits into from
Oct 28, 2021

Conversation

aleeperezz16
Copy link
Contributor

@aleeperezz16 aleeperezz16 commented Oct 24, 2021 •
edited by SergeyShorokhov
Loading

resolve #683

Basically lets players to plant c4 anywhere in the map. CTs are also allowed for mods.

This was referenced Oct 24, 2021
Closed
Closed
SergeyShorokhov
SergeyShorokhov requested changes Oct 28, 2021
View reviewed changes
regamedll/dlls/player.cpp Outdated Show resolved Hide resolved
regamedll/dlls/game.cpp Outdated Show resolved Hide resolved
SergeyShorokhov
SergeyShorokhov requested changes Oct 28, 2021
View reviewed changes
regamedll/dlls/player.cpp Outdated Show resolved Hide resolved
@SergeyShorokhov
Copy link
Member

Thank you for your contribution! Could you also implement here API member m_bPlantC4Anywhere (as in a similar PR) for this functionality?

It would be convenient to manage this from ReAPI (or smth similar).

@aleeperezz16
Copy link
Contributor Author

Yes, of course

@SergeyShorokhov
Copy link
Member

SergeyShorokhov commented Oct 28, 2021 •
edited
Loading

It is worth understanding that this functionality will break the gameplay without adjusting mp_plant_c4_delay. That is, it is dependent. Otherwise, this CVar is not suitable for use by every map.

mp_plant_c4_delay should be implemented in a separate PR

@SergeyShorokhov
Copy link
Member

About naming. I guess we better not deviate from the original source of functionality ( CS:GO mp_plant_c4_anywhere). That way it will be easier to find the description in google and find it in ReGameDLL cmds list.

@SergeyShorokhov
Copy link
Member

Note for the following PRs. Each new functionality must be added at the end of the *.cfg file. (and in readme.md table of CVar's)

@SergeyShorokhov
Copy link
Member

I will test everything later (today or tomorrow) and add it. Thank you for your contributions.

@aleeperezz16
Copy link
Contributor Author

Note for the following PRs. Each new functionality must be added at the end of the *.cfg file. (and in readme.md table of CVar's)

Yeah, I know. I added that below mp_buy_anywhere as it has the "anywhere" and it's implementation is on the same method

@aleeperezz16
Copy link
Contributor Author

I will change these things you commented

@aleeperezz16 aleeperezz16 changed the title New CVar: mp_plant_anywhere New CVar: mp_plant_c4_anywhere Oct 28, 2021
SergeyShorokhov
SergeyShorokhov requested changes Oct 28, 2021
View reviewed changes
regamedll/dlls/game.cpp Outdated Show resolved Hide resolved
regamedll/dlls/game.cpp Outdated Show resolved Hide resolved
regamedll/dlls/game.h Outdated Show resolved Hide resolved
regamedll/dlls/player.cpp Outdated Show resolved Hide resolved
@SergeyShorokhov SergeyShorokhov merged commit 112326a into rehlds:master Oct 28, 2021
@aleeperezz16 aleeperezz16 deleted the plant-anywhere branch October 28, 2021 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyShorokhov SergeyShorokhov SergeyShorokhov approved these changes

Assignees

@aleeperezz16 aleeperezz16

Labels
Priority: Low Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add CVar mp_plant_c4_anywhere
2 participants
@aleeperezz16 @SergeyShorokhov