chore: at-least-once need not be scary #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quettabit
reviewed
Jan 15, 2025
| @@ -143,10 +143,6 @@ class S2: | |||
| enable_append_retries: Enable retries for appends i.e for both :meth:`.Stream.append` and | |||
| :meth:`.Stream.append_session`. Default value is True. | |||
| cloud: Cloud in which the S2 service runs. Currently, only AWS is supported. | |||
|
|
|||
| Caution: | |||
There was a problem hiding this comment.
I think it's a larger discussion than a note -- but in general, duplicate records due to at-least-once semantics are a well-accepted default. We offer a way to mitigate in case there is known to be a single writer (match-seq-num, and if that fails client can re-verify contents of the stream).
quettabit
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.