-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Allow to register new flow dynamically #75
Comments
I think by design it should not require a restart. If this is happening it can be a bug. The idea is to define the workflow in each requests. Even for partial request |
I'm not quite sure, but it seems like the task queue and consumer for each flow are initialized in the |
Are you suggesting that after separating flow and workload, we can attach the complete flow information to each request? That's ok if there is also a method to dynamically register workloads. |
I’ll check this over the weekend |
Hi @s8sg ,how are things going? :) |
hey @s8sg , this is very crucial for a workflow engine |
@Lucifer8729 I would love to know why it’s crucial for a workflow orchestration. For example what kind of business use cases needs this and which other platform provides such support Goflow supposed not to be a traditional workflow engine. It supposed to solve common use cases such as orchestrating a set of task that need to be executed in async reliably. I wanna stress on the reliability part because that is where I think the primary focus for this library should be In my experience I have hardly came across use cases where you need to change the orchestration on the fly very often. For not so common use cases I'll suggest to contribute to the repo so that we can close the high priority items and make progress for the additional requirement such as this |
Duplicate of #66 |
@s8sg To clarify, the goal is not to dynamically change the orchestration during runtime, but to register a new flow, which is a different scenario from #66 . When I use goflow to create a workflow platform similar to Airflow, which allows users to dynamically define and submit new workflows, this is a necessary function. |
@dan2li do you want to register the flow with a new name ? |
I might have misunderstood. I think as long as we are not updating the existing workflow I’m fine to dynamically register a new workflow on the same flow service. Reopening the same |
[Feature] Support dynamically appending flows after the flow service started.
Currently, it is only possible to register a workflow before starting the flow service. If you need to register a new workflow after starting the flow service, a restart is required. We need to provide a more flexible solution in the future.
The text was updated successfully, but these errors were encountered: