-
-
Notifications
You must be signed in to change notification settings - Fork 558
Add animated class to animated buttons #1022
Comments
Hi, @shahednasser,
Use this action on your projects. |
I will take the atom button. Thanks! |
Great @karleypetracca you can go ahead |
One additional consideration on this @shahednasser : will there be a plan to put something like I'd be up for adding this functionality if you're comfortable with that. 😃 |
@karleypetracca I don't think it's necessary for the website at the moment, as it could make it laggy. We could maybe decide in the future to do that, but only play the animation when the button is on screen? This is just an idea but I'm not sure we will work on it at the moment, but thank you for the suggestion! |
I'll take the rainbow button. |
Great @Hrshk15 thanks! |
Indeed ! I've an idea to improve the UI/UX of animated buttons. I can add the toggle animated class functionality in such way that it won't affect the other contributors work. Will discuss this further on your acknowledgement. |
How many of them can I take? I will take Aura and Bounce if I can take more than one. Thank you! |
@adsingh14 great but toggle button is not on the list above so please choose one of the buttons from the list and let me know which |
sure @TomWBush you can |
I can take the next three, Diagonal Background on Hover, Expanding Border, Fill Buttons All Types. One question I have is that Expanding Border does not seem to have a continuous animation on hover. Do you want me to make it continuous for the animated class? |
Thanks @TomWBush . No I think that was a mistake, it's not supposed to be continuous. I'll edit that. |
@shahednasser I wasn't talking about toggle button from the list. I was suggesting adding toggle functionality button for animated buttons. |
@adsingh14 oh do you mean on the website adding a toggle functionality that adds or removes the |
@shahednasser hello, can I take flash, hinge, invert? |
Yes @yuwangcs you can |
Hi @shahednasser |
Hi @shahednasser ,I want to contribute here ,can you let me know which one is available? |
Hi @kalimah-apps I have assigned you to hinge |
Hello @karishmapatel27 @princeo1 the ones that are not checked off and do not have next to them "taken by" are available. Please comment which ones you'd like to work on to be assigned to them |
Hi @shahednasser, thank you for coming back to me. I would like to work on Invert please. |
Great I have assigned you the button |
Thank you for replying @shahednasser I would like to work on rainbow |
Great @princeo1 you're assigned |
Hi @shahednasser I'm new to the project and would like to contribute. Please feel free to assign me a task ✅ |
Hi @arnoldgee please choose a button from the list if you want to work on it! |
@shahednasser reporting a stale issue. |
Hi @shahednasser I would also like to contribute here . Can I work on the Flash Button ? |
Hello @TanmayJain17 yes you can I'll assign you |
Hello @shahednasser can I work on the Liquid and the Rainbow button? |
Hello @shahednasser can i take these |
Hey @shahednasser can i take the Snake Border ? |
Hello @rad10wave yes I'll assign you |
Most animated button's animation only happens on hover, we need to add an
animated
class that triggers the animation without hovering over the button. And when the animation class is added make sure that the animation is not also triggered on hover. In order to avoid repeated code in the buttons, please move the animation or transition to a mixin and call it where it is needed.Also, some button's animation needs to be continuous, others don't. I have indicated below which is continuous and which isn't
This issue is going to be split between contributors. Each contributor can take up a button from the list below. Please comment before taking up a button, choosing which between you will be working on.
The following buttons need the
animated
class:The text was updated successfully, but these errors were encountered: