Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error when markSearchResults: true #209

Closed
daeyoonlee opened this issue Dec 17, 2022 · 5 comments
Closed

error when markSearchResults: true #209

daeyoonlee opened this issue Dec 17, 2022 · 5 comments
Assignees
@gnbm
Labels
bug Something isn't working

Comments

@daeyoonlee
Copy link

Thank you for the great program.

When markSearchResults: true, searching with * or ( ) generates a regular expression error.

image

image
@sa-si-dev
Copy link
Owner

@daeyoonlee thanks for letting me know it. I will check and fix it in the future release.

@sa-si-dev sa-si-dev self-assigned this Dec 17, 2022
@sa-si-dev sa-si-dev added the bug Something isn't working label Dec 17, 2022
@daeyoonlee
Copy link
Author

Thank you

@gnbm
Copy link
Collaborator

gnbm commented Dec 23, 2022 •
edited
Loading

@sa-si-dev I did a PR for this. Please take a look and hope it helps 🎄🎅🏻

@sa-si-dev
Copy link
Owner

@sa-si-dev I did a PR for this. Please take a look and hope it helps 🎄🎅🏻

@gnbm thanks for your contribution. I will merge it in the next release.

@sa-si-dev sa-si-dev assigned gnbm and unassigned sa-si-dev Dec 28, 2022
@sa-si-dev
Copy link
Owner

@daeyoonlee This issue has been fixed in the release v1.0.37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gnbm gnbm

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gnbm @daeyoonlee @sa-si-dev