Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use s3ninja for custom provider testing #174

Open
sa7mon opened this issue Aug 9, 2023 · 1 comment
Open

use s3ninja for custom provider testing #174

sa7mon opened this issue Aug 9, 2023 · 1 comment
Labels
refactor Code cleanup / optimization
Milestone

Comments

@sa7mon
Copy link
Owner

sa7mon commented Aug 9, 2023

Vultr objects is just too flaky to depend on for automated testing. Fire up an S3 Ninja container, programmatically create some test buckets, and use those for testing.

@sa7mon sa7mon added the refactor Code cleanup / optimization label Aug 9, 2023
@sa7mon sa7mon added this to the Future milestone Aug 9, 2023
@sa7mon
Copy link
Owner Author

sa7mon commented Aug 18, 2023

s3 ninja is not fully featured. gofakes3 is close but doesn't support bucket permissions at all. We may just need to use httptest and assert the HTTP calls look correct. Current work in branch 174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Code cleanup / optimization
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant