Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: White line above file-input-sm #1700

Closed
dgmp88 opened this issue Mar 21, 2023 · 2 comments
Closed

bug: White line above file-input-sm #1700

dgmp88 opened this issue Mar 21, 2023 · 2 comments

Comments

@dgmp88
Copy link
Contributor

dgmp88 commented Mar 21, 2023

What version of daisyUI are you using?

2.50.1

Describe your issue

file-input-sm has a white line that appears at the top:
Screenshot 2023-03-21 at 10 17 41

It's visible for me on Chrome and Safari (not tested on others) on the docs page too. Taking away the top border helps

Thanks for the awesome work, Daisy UI is amazing! :D

What browsers are you seeing the problem on?

Chrome, Safari

Reproduction URL (optional)

https://play.tailwindcss.com/81BGI2e2eW

@hebontes
Copy link

hebontes commented Mar 21, 2023

Problem

file-input-lg and file-input-md have line-height set to 2.0

file-input-xs has line-height set to 1.625

for some reason, file-input-sm has line-height set to 2rem which is taller than height of input, that's why you see white line between top border and input.

FIX manually

converting file-input-sm line-height to 1.625 just like file-input-xs will fix the issue.
You can do this manually in global styles .file-input-sm{@apply leading-relaxed}

FIX in source

We just need to change /utilities/unstyled/file-input.css line 10 from leading-8 to leading-relaxed, I created a branch and tried to push but access denied, sorry this is my first try to contribute on github.

@saadeghi
Copy link
Owner

Fixed in 2.51.5: https://play.tailwindcss.com/AceZOOyFcg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants