-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Choice Node Integration #43
Comments
what are you roughly expecting this to look like? |
Whenever the choice node is jumped to, all the possible choices are displayed in cmp (potentially excluding the currently selected one?) and the user can confirm their selection immediately causing it to expand. It would essentially be the same as this just integrated into cmp instead. |
I'm not really sure if integrating with cmp is possible as the sources just provide completion candidates and how to resolve them. A hacky way would be instead of passing snippets we pass in the choice node candidates when a choice node is active but that'd still leave the issue of completion candidate from other sources such as lsp/buffer polluting the completion menu. @L3MON4D3 any thoughts on this? |
I believe it possible to specify source priorities such that if one source returns completions none of the others are queried which should solve the pollution issue. Can't really speak to the rest of the problem however. |
In case you're not aware @p0da, luasnip already has integration with
I think it should be doable, take a look at this piece of code from the
|
I can definitely try this out. Will try to create a PR in a few days once I have some time 😄 |
Nice, looking forward to it👍 |
I would like to revive this issue and ask if you could add native choice node integration into this cmp source. While it certainly possible to create an alternative popup menu, having choice nodes integrated will streamline workflows (unified settings and styles). Thanks for considering.
The text was updated successfully, but these errors were encountered: