Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is no way to know which version of saagieapi is compatible with which version of Saagie #72

Closed
Andromelus opened this issue Feb 28, 2022 · 3 comments · May be fixed by #82
Closed

There is no way to know which version of saagieapi is compatible with which version of Saagie #72

Andromelus opened this issue Feb 28, 2022 · 3 comments · May be fixed by #82
Assignees
@tquiviger
Labels
feature New feature or request SaagieAPI

Comments

@Andromelus
Copy link

Is your feature request related to a problem? Please describe.
Our platform got a breaking change in its API. I wanted to know which version of saagieapi I should use, but the release description does not specify which version of Saagie is compatible with the releases of saagieapi.

Describe the solution you'd like
In each release note, it should be specified which version(s) of Saagie is supported.
Additionnaly, saagieapi package should check directly with the Saagie platform if it is compatible.
For example, When creating an object from SaagieApi class, the init should query /version (or something similar) to check if the version of the API is handled by the package. If not, raise Exception with specific message.
@Andromelus Andromelus added feature New feature or request SaagieAPI labels Feb 28, 2022
@saagie-service
Copy link
Collaborator

Trello card: [#72] There is no way to know which version of saagieapi is compatible with Saagie

@Andromelus Andromelus changed the title There is no way to know which version of saagieapi is compatible with Saagie There is no way to know which version of saagieapi is compatible with whitch version of Saagie Feb 28, 2022
@Andromelus Andromelus changed the title There is no way to know which version of saagieapi is compatible with whitch version of Saagie There is no way to know which version of saagieapi is compatible with which version of Saagie Mar 1, 2022
@tquiviger
Copy link
Contributor

Hi @floriancastelain , that's something we detected as well. We should have in a near future an endpoint API in Saagie that would return the current Saagie version and that could help us achieve what you're describing. Let's keep this issue open until then.

@tquiviger tquiviger self-assigned this Mar 22, 2022
@tquiviger tquiviger mentioned this issue Apr 7, 2022
Draft
@guillaumeprevost76
Copy link
Collaborator

Hello,

We created a versioned documentation since version 2.3.0 accessible here : https://saagieapi.readthedocs.io/en/latest/ with a table of correspondance between SaagieAPI version and Saagie Platform version.
So we consider that is issue is not relevant anymore and close it.

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tquiviger tquiviger

Labels
feature New feature or request SaagieAPI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat/saagie version saagie/api-saagie
4 participants
@tquiviger @Andromelus @guillaumeprevost76 @saagie-service