Infinite loop in logicalAnd migration

[nhovratov]

Bug Report

This issue is related to #2861

When I ran rector, it took oddly long. I canceled the run and had a look, what happened:

Rector tried to migrate:

        if (\count($constraints) > 0) {
            $query->matching(
                $query->logicalAnd($constraints)
            );
        }

The result was:

        if (\count($constraints) > 0) {
            if (count($constraints) === 1) {
                $query->matching(reset($constraints));
            } elseif (count($constraints) >= 2) {
                if (count($constraints) === 1) {
                    $query->matching(reset($constraints));
                } elseif (count($constraints) >= 2) {
                    if (count($constraints) === 1) {
                        $query->matching(reset($constraints));
                    }
                    ...
                        }
                        $query->matching($query->logicalAnd(...$constraints));
                    }
                    $query->matching($query->logicalAnd(...$constraints));
                }
                $query->matching($query->logicalAnd(...$constraints));
            }

[nhovratov]

This seems to be an issue with a composer dependency. When I ran the test suite in my local rector environment, it failed:

/usr/bin/php /home/nikita/projects/typo3-rector/vendor/phpunit/phpunit/phpunit --configuration /home/nikita/projects/typo3-rector/phpunit.xml --filter Ssch\\TYPO3Rector\\Tests\\Rector\\v12\\v0\\typo3\\HardenMethodSignatureOfLogicalAndAndLogicalOrRector\\HardenMethodSignatureOfLogicalAndAndLogicalOrRectorTest --test-suffix HardenMethodSignatureOfLogicalAndAndLogicalOrRectorTest.php /home/nikita/projects/typo3-rector/tests/Rector/v12/v0/typo3/HardenMethodSignatureOfLogicalAndAndLogicalOrRector --teamcity
Testing started at 12:43 ...
PHPUnit 9.6.5 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.2.13
Configuration: /home/nikita/projects/typo3-rector/phpunit.xml


Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
         if (count($queryConstraints) === 1) {
             $query->matching(reset($queryConstraints));
         } elseif (count($queryConstraints) >= 2) {
+            if (count($queryConstraints) === 1) {
+                $query->matching(reset($queryConstraints));
+            } elseif (count($queryConstraints) >= 2) {
+                $query->matching($query->logicalAnd(...$queryConstraints));
+            }
             $query->matching($query->logicalAnd(...$queryConstraints));
         }
         $query->setOrderings(['uid' => QueryInterface::ORDER_DESCENDING]);
@@ @@
         if (count($queryConstraints) === 1) {
             $query->matching(reset($queryConstraints));
         } elseif (count($queryConstraints) >= 2) {
+            if (count($queryConstraints) === 1) {
+                $query->matching(reset($queryConstraints));
+            } elseif (count($queryConstraints) >= 2) {
+                $query->matching($query->logicalAnd(...$queryConstraints));
+            }
             $query->matching($query->logicalAnd(...$queryConstraints));
         }
         $query->setOrderings(['uid' => QueryInterface::ORDER_DESCENDING]);

 /home/nikita/projects/typo3-rector/vendor/rector/rector/packages/Testing/PHPUnit/AbstractRectorTestCase.php:145
 /home/nikita/projects/typo3-rector/vendor/rector/rector/packages/Testing/PHPUnit/AbstractRectorTestCase.php:116
 /home/nikita/projects/typo3-rector/tests/Rector/v12/v0/typo3/HardenMethodSignatureOfLogicalAndAndLogicalOrRector/HardenMethodSignatureOfLogicalAndAndLogicalOrRectorTest.php:17

After composer update the test was green. I have not figured out yet, which dependency is responsible.

[nhovratov]

Added a PR to showcase the error: #3929
Seems to be an error when running the rector multiple times.

[simonschaufi]

Fixed! This rule is super complex and I hope it works now as expected.

[nhovratov]

Thanks! Yes, it is indeed. It works fine otherwise :)