Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingress support #19

Closed
r3mcos3 opened this issue Apr 16, 2019 · 9 comments
Closed

Ingress support #19

r3mcos3 opened this issue Apr 16, 2019 · 9 comments
Assignees
Labels
new feature New feature or request

Comments

@r3mcos3
Copy link

r3mcos3 commented Apr 16, 2019

Thank you for this amazing addon!

But are you planning to support ingress?
https://www.home-assistant.io/blog/

Thank you

@r3mcos3 r3mcos3 changed the title Ingress supoort Ingress support Apr 16, 2019
@sabeechen
Copy link
Owner

Plan to, I'll just have to sort out how to do it without breaking everybody who hasn't updated yet. Might give it a good while to let people get on board with the recent releases first.

@sabeechen sabeechen self-assigned this Apr 16, 2019
@sabeechen sabeechen added the new feature New feature or request label Apr 16, 2019
@r3mcos3
Copy link
Author

r3mcos3 commented Apr 16, 2019

Ok, thnx for you're quick response 👍

@sabeechen
Copy link
Owner

I've done a lot of messing around with ingress enabled on various versions of Home assistant, and I think I'm going to need to wait a while before I can turn it on without making a hassle for at least some of my users. Many versions of Home Assistant below the official ingress supported version (0.91.3) recognize that and add-on has ingress enabled but error out when trying to render the ingress-ed page.

This puts me in a position where I can either require the latest version of HA forcing users to upgrade HA if they want the latest version of the add-on, or I can enable it without requiring the latest version which would make a broken experience for those with HA before 0.91.3.

I might be missing something, but I don't think the Hassio folks gave add-on developers a backwards-compatible upgrade path for supporting ingress. Looking through the forum, it seems there is a lot of turmoil with the breaking changes involved with the add-ons that did update, so I'm going keep this shelved for a little while and see how things play out.

@r3mcos3
Copy link
Author

r3mcos3 commented Apr 19, 2019

Ok, fair answer! The addon works great, if you think it's not the right step to take now, Maybe I see it in the future, keep up the good work 👍

@mattkerrison
Copy link

+1 Ingress support would be great

@marrobHD
Copy link

marrobHD commented Jul 1, 2019

+1 I am also for ingress

@31337Ghost
Copy link

31337Ghost commented Jul 15, 2019

@sabeechen you could also create additional dev add-on repository with version which supports ingress. Any case thank you for your great work 🙌

@ronmichel
Copy link

Thank you for the addon! Ingress would be very welcome!

@sabeechen
Copy link
Owner

Took me a while to get there, but I've enabled ingress in the latest release, v0.98.1. Make sure you refresh the add-on store page to make Hass.io see the update faster if you'd like to update now, and let me know if you run into trouble.

Upgrading an add-on to support ingress has caused a lot of confusion for users in the past since the "old" way of access the web UI from an exposed port usually gets turned off. To mitigate that, if you're upgrading the add-on from an older version you'll see a dialog in the web-ui asking if you'd like to switch over to access the UI through ingress only. The web-ui will still be available from the "old" port until you choose, and the choice can be changed from the setting menu at any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants