Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comply with EIP-165 #330

Closed
smol-ninja opened this issue Nov 11, 2024 · 0 comments · Fixed by #333
Closed

Comply with EIP-165 #330

smol-ninja opened this issue Nov 11, 2024 · 0 comments · Fixed by #333
Assignees
@smol-ninja
Labels
effort: low Easy or tiny task that takes less than a day. priority: 0 Do this first before everything else. This is critical and nothing works without this. type: feature New feature or request. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.

Comments

@smol-ninja
Copy link
Member

smol-ninja commented Nov 11, 2024 •
edited
Loading

Since SablierFlowBase inherits from EIP4906, add the following function to comply with EIP 165:

/// @inheritdoc ERC721
function supportsInterface(bytes4 interfaceId) public view override(IERC165, ERC721) returns (bool) {
    // 0x49064906 is the ERC-165 interface ID required by ERC-4906
    return interfaceId == 0x49064906 || super.supportsInterface(interfaceId);
}

Reported in Codehawk audit.
@smol-ninja smol-ninja added priority: 0 Do this first before everything else. This is critical and nothing works without this. effort: low Easy or tiny task that takes less than a day. type: feature New feature or request. work: clear Sense-categorize-respond. The relationship between cause and effect is clear. labels Nov 11, 2024
@smol-ninja smol-ninja self-assigned this Nov 11, 2024
@smol-ninja smol-ninja mentioned this issue Nov 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smol-ninja smol-ninja

Labels
effort: low Easy or tiny task that takes less than a day. priority: 0 Do this first before everything else. This is critical and nothing works without this. type: feature New feature or request. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support EIP165 interface sablier-labs/flow
1 participant
@smol-ninja