Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the deploy multi chain script #971

Closed
andreivladbrg opened this issue Jul 15, 2024 · 3 comments
Closed

Improve the deploy multi chain script #971

andreivladbrg opened this issue Jul 15, 2024 · 3 comments
Assignees
@andreivladbrg
Labels
effort: medium Default level of effort. priority: 2 We will do our best to deal with this. type: refactor Change that neither fixes a bug nor adds a feature. work: complex Probe-sense-respond. The relationship between cause and effect can only be perceived in retrospect.

Comments

@andreivladbrg
Copy link
Member

andreivladbrg commented Jul 15, 2024 •
edited
Loading

With the latest release, I had to use the deploy multi chain script, and there are some things that we can do to improve the DX for this:

  • don't exit the script execution if one chain's deployment fails, ref
  • generate only one deployment file (push with a header the deployment)
  • don't delete the previous deployment (if already in file, copy it to a backup file)
  • print what CLI has been used
  • mention in the deployment file if it is broadcasted or it is a simulation
  • add a cp command to copy the broadcast file from the current dir to deployments dir (ofc first check if the dir exists at that path, if not skip it)
    • e.g. cp broadcast/DeployDeterministicCore.s.sol/1/run-latest.json ../v2-deployments/core/v1.2.0/broadcasts/mainnet.json

@smol-ninja tagging to ask for objections
@andreivladbrg andreivladbrg added work: complex Probe-sense-respond. The relationship between cause and effect can only be perceived in retrospect. type: refactor Change that neither fixes a bug nor adds a feature. priority: 2 We will do our best to deal with this. effort: medium Default level of effort. labels Jul 15, 2024
@smol-ninja
Copy link
Member

Good idea and no objection from my side.

@andreivladbrg andreivladbrg self-assigned this Jul 17, 2024
@andreivladbrg andreivladbrg mentioned this issue Aug 22, 2024
Closed
@andreivladbrg andreivladbrg linked a pull request Aug 22, 2024 that will close this issue
Add deploy multi chain rust script #1021
Closed
@smol-ninja
Copy link
Member

Should we close this @andreivladbrg ?

@andreivladbrg
Copy link
Member Author

yes, we should, also created #1059

@andreivladbrg andreivladbrg closed this as not planned Won't fix, can't repro, duplicate, stale Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreivladbrg andreivladbrg

Labels
effort: medium Default level of effort. priority: 2 We will do our best to deal with this. type: refactor Change that neither fixes a bug nor adds a feature. work: complex Probe-sense-respond. The relationship between cause and effect can only be perceived in retrospect.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add deploy multi chain rust script sablier-labs/v2-core
2 participants
@smol-ninja @andreivladbrg