New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test all values initialized at construction time #291

Closed

3 tasks done

PaulRBerg opened this issue Jan 24, 2023 · 0 comments · Fixed by #284

Closed

3 tasks done

Test all values initialized at construction time #291

PaulRBerg opened this issue Jan 24, 2023 · 0 comments · Fixed by #284

Assignees

Member

PaulRBerg commented Jan 24, 2023 •

edited

Loading

As pointed out by @andreivladbrg in #271 (review), we are not yet testing all the values that gets set at construction time.

We should update the constructor tests for the SablierV2LockupLinear and SablierV2LockupPro contracts to run the following checks:

initialAdmin gets set to the correct value
comptroller gets set to the correct value
maxFee gets set to the correct value

The text was updated successfully, but these errors were encountered:

PaulRBerg added testing labels

PaulRBerg self-assigned this

PaulRBerg mentioned this issue

Test reorg + various improvements #284

Merged

14 tasks

PaulRBerg closed this as completed in #284

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment