-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the e2e tests failure due to "Blacklistable: account is blacklisted" #317
Comments
UPDATE: I tried implementing this, but this ain't easy, in the sense that we would have to add quite a a bit of logic to our end-to-end tests. Foundry doesn't have a way to ignore certain revert reason strings, so the only way to ignore them would be to use the try/catch in all calls to the linear and the pro contracts (USDC checks that both the sender and the recipient are not blacklisted, see lines 837 and 837 here). That would make the e2e tests even complicated than they already are. Therefore, given these constraints, I will proceed with closing this issue as not planned. |
FWIW, I have just created an issue in the Foundry repo to suggest the addition of a new feature that would make for a better UX here. |
Going to reopen this issue because we keep bumping into the blacklistable error in our CI end-to-end tests: https://github.com/sablierhq/v2-core/actions/runs/4187172153/jobs/7256695965 |
USDC has a built-in black listing mechanism, and once every so often our end-to-end tests fails because of this revert reason:
What happens is that Foundry fuzzes a user that has been blacklisted. We should exclude this edge case and do not fail the tests.
The text was updated successfully, but these errors were encountered: