Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the default constant and params in the tests #438

Closed
PaulRBerg opened this issue Apr 17, 2023 · 0 comments
Closed

Refactor the default constant and params in the tests #438

PaulRBerg opened this issue Apr 17, 2023 · 0 comments
Assignees
@PaulRBerg

Comments

@PaulRBerg
Copy link
Member

PaulRBerg commented Apr 17, 2023 •
edited by andreivladbrg
Loading

Refactor the Constants and the defaultParams to follow the approach we have taken in the periphery repo:

https://github.com/sablierhq/v2-periphery/blob/main/test/helpers/Defaults.t.sol

Kudos to @andreivladbrg for coming up with this design.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PaulRBerg PaulRBerg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PaulRBerg