Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settled streams should not be renounceable #457

Closed
PaulRBerg opened this issue Apr 24, 2023 · 0 comments
Closed

Settled streams should not be renounceable #457

PaulRBerg opened this issue Apr 24, 2023 · 0 comments
Assignees
@PaulRBerg

Comments

@PaulRBerg
Copy link
Member

The renounce functions allows settled streams to be renounced:

https://github.com/sablierhq/v2-core/blob/2b71d0762706ad04cdad58e37d2c6db0b6274496/src/abstracts/SablierV2Lockup.sol#L147-L155

But this is a pointless operation, because settled streams cannot be canceled anymore:

https://github.com/sablierhq/v2-core/blob/2b71d0762706ad04cdad58e37d2c6db0b6274496/src/SablierV2LockupLinear.sol#L370-L372
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PaulRBerg PaulRBerg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PaulRBerg