Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patcher not working with systems using languages other than English #2

Closed
mig99d opened this issue Feb 19, 2019 · 1 comment
Closed

Comments

@mig99d
Copy link

mig99d commented Feb 19, 2019

My machine is using Portuguese (LANG="pt_PT.utf8@euro") as the default language locale. The output of readelf is also fully translated. In my case the patcher is not able to find the "File:" string when parsing the readelf output and so fails to do anything.
I managed to work around it by changing the LANG environment variable to "en" when running the script.

I think a reasonable and easy way to fix this is to have the script itself override the LANG variable, so that the output of readelf can be correctly parsed even if the system default is not English. Most machines should have English support, and if not then the script as is won't work anyway.

@saboya saboya closed this as completed in 3f1577e Feb 19, 2019
@saboya
Copy link
Owner

saboya commented Feb 19, 2019

Should be fixed with 3f1577e.

Thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants