Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

info icons sometimes not generated for files in the Browser plugin #720

Closed
mcassaniti opened this issue Sep 16, 2015 · 1 comment
Closed
Labels
Milestone

Comments

@mcassaniti
Copy link

Hi,
It took me a while to find out what was going on here since I have my own directory and file classes. What I found (which is still an issue in master) is that in DAV\Browser\Plugin.php in function generateDirectoryIndex, the line if ($subNode instanceof DAV\IFile) should be changed to if ($subProps['subNode'] instanceof DAV\IFile) (approx line 319).

Currently the code uses the last $subNode value from the previous loop, which in some cases is not an instance of DAV\IFile. Should be a simple fix.

@evert evert added the bug label Jan 5, 2016
@evert evert added this to the 3.1 milestone Jan 5, 2016
@evert
Copy link
Member

evert commented Jan 5, 2016

Thank you! This was recently fixed on master.

@evert evert closed this as completed Jan 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants