Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple functions per event #5

Open
lkarlslund opened this issue Jun 8, 2017 · 4 comments
Open

Multiple functions per event #5

lkarlslund opened this issue Jun 8, 2017 · 4 comments

Comments

@lkarlslund
Copy link

I forked your project, and added multiple functions per event. Also I introduced interfaces for Event and Function, which improves speed and adds functionality.

The only breaking change is that calling Fire(...) now returns [][]reflect.Value() instead of []reflect.Value()

Also the return channel is closed after functions complete.

I suggest you look at it at https://github.com/lkarlslund/go-trigger and give feedback.

@sadlil
Copy link
Owner

sadlil commented Jun 20, 2017

This looks okay. would you mind update docs, adding some tests and sending a PR and lets have a review.

@pauldotknopf
Copy link

This has been a while, any update on this?

Should I just use the fork?

@sadlil
Copy link
Owner

sadlil commented Feb 26, 2018

@lkarlslund do like to send over a PR? i can also contribute some on it.

@lkarlslund
Copy link
Author

Sorry, I've not maintained my external version of the package for a while. The one I'm using internally is not release ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants