Add NotificationPreference for weekly reminder
#1867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix #1863 - By default, preference is set to `false` - After this PR got merge, need to run one-off script to generate NotificationPreference records
added 5 commits
June 26, 2024 11:45
- Fix styling for desktop and mobile screens - Use ReminderIcon(Bell Ringing Icon) for notification - Use CustomToggle instead of Checkbox for enable/disable notification
…cept the invitaton
gowsik-ragunath
approved these changes
Jul 5, 2024
Comment on lines
+11
to
16
| notification_preference = NotificationPreference.find_by(user_id: user.id, company_id: company.id) | ||
|
|
||
| if notification_preference.present? && notification_preference.notification_enabled | ||
| check_entries_and_send_mail(user, company) | ||
| end | ||
| end |
There was a problem hiding this comment.
Suggestion: I think it would be better if we have this check in SendWeeklyReminderToUserMailer, so that even when we trigger mailer manually, it won't send any email if the user's notification preference is not satisfied.
In future, we can even have this as a before action check in the application mailer, If we plan to use this notification preference for all the mail notifications.
apoorv1316
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
falseNotificationPreferencerecords