Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iterate over chains when getting all Safes by owner #2001

Closed
iamacook opened this issue Oct 8, 2024 · 0 comments · Fixed by #2002
Closed

Iterate over chains when getting all Safes by owner #2001

iamacook opened this issue Oct 8, 2024 · 0 comments · Fixed by #2002
Assignees

Comments

@iamacook
Copy link
Member

iamacook commented Oct 8, 2024

Description

When calling getAllSafesByOwner, we expect the response from the Config Service to not be longer than one page. As a temporary fix (as this also affected the clients), we increased the page size o Chains. This is, however, not the correct way to paginated. We should, instead iterate of the pages if a next value is present.

Requirements

  1. Call getChains and determine if there is a next value, calling that thereafter and concatenating the results.
  2. Else return concatenated results.

Additional information

We should consider whether we do this on the chains repository level in case getChains is called anywhere without a limit, etc.

After this we should consider reverting the page size of chains (if we have that many configurations saved).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant