You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When calling getAllSafesByOwner, we expect the response from the Config Service to not be longer than one page. As a temporary fix (as this also affected the clients), we increased the page size o Chains. This is, however, not the correct way to paginated. We should, instead iterate of the pages if a next value is present.
Requirements
Call getChains and determine if there is a next value, calling that thereafter and concatenating the results.
Else return concatenated results.
Additional information
We should consider whether we do this on the chains repository level in case getChains is called anywhere without a limit, etc.
After this we should consider reverting the page size of chains (if we have that many configurations saved).
The text was updated successfully, but these errors were encountered:
Description
When calling
getAllSafesByOwner
, we expect the response from the Config Service to not be longer than one page. As a temporary fix (as this also affected the clients), we increased the page size oChains
. This is, however, not the correct way to paginated. We should, instead iterate of the pages if anext
value is present.Requirements
getChains
and determine if there is anext
value, calling that thereafter and concatenating theresults
.results
.Additional information
We should consider whether we do this on the chains repository level in case
getChains
is called anywhere without a limit, etc.After this we should consider reverting the page size of chains (if we have that many configurations saved).
The text was updated successfully, but these errors were encountered: