Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[relay-kit] Specify custom nonce and checksum addresses #1082

Closed
yagopv opened this issue Dec 18, 2024 · 0 comments · Fixed by #1126
Closed

[relay-kit] Specify custom nonce and checksum addresses #1082

yagopv opened this issue Dec 18, 2024 · 0 comments · Fixed by #1126
Assignees
@yagopv

Comments

@yagopv
Copy link
Member

yagopv commented Dec 18, 2024

Context / issue

The relay-kit can be improved in several ways

Proposed solution

  1. Allow the Safe4337Pack to specify a custom nonce
  2. The code that adds the shared-signer to the owners array doesn't checksum addresses. There's a chance the shared-signer address ends up twice in the array

Additional context

https://docs.pimlico.io/permissionless/how-to/parallel-transactions#sending-multiple-user-operations-in-parallel
@yagopv yagopv assigned yagopv and unassigned yagopv Dec 18, 2024
@dasanra dasanra changed the title relay-kit improvements [relay-kit] Specify custom nonce and checksum addresses Feb 10, 2025
@dasanra dasanra linked a pull request Feb 10, 2025 that will close this issue
feat(relay-kit): Add UserOperation custom nonce support #1126
Merged
@yagopv yagopv closed this as completed Feb 10, 2025
@yagopv yagopv mentioned this issue Feb 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yagopv yagopv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(relay-kit): Add UserOperation custom nonce support safe-global/safe-core-sdk
1 participant
@yagopv