-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RPC independence based on chainlist RPC list for review #688
Comments
Why do you need the website? They website uses the JSON files hosted on github: https://github.com/ethereum-lists/chains/tree/master/_data/chains |
Yes, we could use the official Chainlist repo as well, which is mentioned in the Alternatives section of the issue. |
The repo in the alternatives is the defillama chainlist, but we follow the one I linked |
But we did require that the chain should be listed on https://chainlist.org/ right? Or am I mistaken? |
It uses the chainlist from the ethereum-lists repo: https://github.com/DefiLlama/chainlist/blob/main/utils/fetch.js#L99 |
TIL about it! Thanks! Updated the initial description. |
Currently, the chain ID and the RPC link are provided by the person who creates the PR with the contracts being added.
As an added security, we could retrieve the RPC list from the
ethereum-lists/chains
repo and use that in the script.Expected Outcome
ethereum-lists/chains
repo: https://github.com/ethereum-lists/chains/tree/master/_data/chains (thanks @mmv08)Alternatives
The text was updated successfully, but these errors were encountered: