Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC independence based on chainlist RPC list for review #688

Open
remedcu opened this issue Jul 9, 2024 · 6 comments
Open

RPC independence based on chainlist RPC list for review #688

remedcu opened this issue Jul 9, 2024 · 6 comments

Comments

@remedcu
Copy link
Member

remedcu commented Jul 9, 2024

Currently, the chain ID and the RPC link are provided by the person who creates the PR with the contracts being added.

As an added security, we could retrieve the RPC list from the ethereum-lists/chains repo and use that in the script.

Expected Outcome

Alternatives

@mmv08
Copy link
Member

mmv08 commented Jul 9, 2024

Possible Issue: If we parse based on the website structure, then changes in the website might break the script.

Why do you need the website? They website uses the JSON files hosted on github: https://github.com/ethereum-lists/chains/tree/master/_data/chains

@remedcu
Copy link
Member Author

remedcu commented Jul 10, 2024

Yes, we could use the official Chainlist repo as well, which is mentioned in the Alternatives section of the issue.

@mmv08
Copy link
Member

mmv08 commented Jul 10, 2024

Yes, we could use the official Chainlist repo as well, which is mentioned in the Alternatives section of the issue.

The repo in the alternatives is the defillama chainlist, but we follow the one I linked

@remedcu
Copy link
Member Author

remedcu commented Jul 10, 2024

But we did require that the chain should be listed on https://chainlist.org/ right? Or am I mistaken?

@mmv08
Copy link
Member

mmv08 commented Jul 10, 2024

But we did require that the chain should be listed on https://chainlist.org/ right? Or am I mistaken?

It uses the chainlist from the ethereum-lists repo: https://github.com/DefiLlama/chainlist/blob/main/utils/fetch.js#L99

@remedcu
Copy link
Member Author

remedcu commented Jul 10, 2024

TIL about it! Thanks! Updated the initial description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants