Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing return types to Safe #1323

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Add missing return types to Safe #1323

merged 3 commits into from
Sep 12, 2024

Conversation

Uxio0
Copy link
Member

@Uxio0 Uxio0 commented Sep 11, 2024

No description provided.

@Uxio0 Uxio0 requested a review from a team as a code owner September 11, 2024 12:38
@coveralls
Copy link

coveralls commented Sep 11, 2024

Pull Request Test Coverage Report for Build 10830033484

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 21 of 23 (91.3%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.06%) to 93.494%

Changes Missing Coverage Covered Lines Changed/Added Lines %
safe_eth/eth/ethereum_client.py 13 15 86.67%
Files with Coverage Reduction New Missed Lines %
safe_eth/eth/ethereum_client.py 1 85.67%
safe_eth/eth/clients/blockscout_client.py 2 93.94%
Totals Coverage Status
Change from base Build 10793540350: -0.06%
Covered Lines: 8780
Relevant Lines: 9391

💛 - Coveralls

@Uxio0
Copy link
Member Author

Uxio0 commented Sep 11, 2024

@falvaradorodriguez added more fixes to EthereumClient

@falvaradorodriguez falvaradorodriguez dismissed their stale review September 11, 2024 14:14

Please check the tests, it seems that the new assert does not work in all cases.

@Uxio0
Copy link
Member Author

Uxio0 commented Sep 12, 2024

Sorry for the typo, fixed

@Uxio0 Uxio0 merged commit a049c4b into main Sep 12, 2024
7 checks passed
@Uxio0 Uxio0 deleted the add-typing-missing branch September 12, 2024 12:37
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants