Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Safe Creation] Connect wallet step #1003

Closed
usame-algan opened this issue Oct 28, 2022 · 1 comment · Fixed by #1006
Closed

[Safe Creation] Connect wallet step #1003

usame-algan opened this issue Oct 28, 2022 · 1 comment · Fixed by #1006
Assignees
@usame-algan

Comments

@usame-algan
Copy link
Member

usame-algan commented Oct 28, 2022 •
edited
Loading

What is the feature about

Implements the connect wallet + mobile QR as first step in safe creation.

The list of requirements

  • Should be the first step in safe creation
  • Should display a button to connect with the wallet
  • Should display a QR code for mobile pairing
  • If the wallet is disconnected at any step of the safe creation it should jump back to this step

Designs/sketches

Screenshot 2022-11-16 at 10 36 23

Links

Figma: https://www.figma.com/file/ptTs6lDBeUuLNySroJ5PiF/Web-Master-File?node-id=51%3A5661
@usame-algan usame-algan moved this to Todo in Safe{Wallet} Oct 28, 2022
@usame-algan usame-algan mentioned this issue Oct 28, 2022
Merged
@DiogoSoaress
Copy link
Member

Also to complete this point

If the wallet is disconnected at any step of the safe creation it should either jump back to this step or disable the continue button

we previously discussed to disable the "continue" button if the wallet is in the wrong chain

@usame-algan usame-algan moved this from Todo to In Progress in Safe{Wallet} Oct 28, 2022
@usame-algan usame-algan self-assigned this Oct 28, 2022
@usame-algan usame-algan mentioned this issue Oct 31, 2022
Merged
@usame-algan usame-algan moved this from In Progress to Peer Review in Safe{Wallet} Oct 31, 2022
@usame-algan usame-algan mentioned this issue Oct 31, 2022
Closed
13 tasks
Repository owner moved this from Peer Review to Done in Safe{Wallet} Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@usame-algan usame-algan

Labels
None yet
Projects
Safe{Wallet}
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Create Safe] feat: Connect wallet step safe-global/safe-wallet-monorepo
2 participants
@usame-algan @DiogoSoaress