Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some icons are too small #1025

Closed
katspaugh opened this issue Nov 1, 2022 · 3 comments · Fixed by #1031
Closed

Some icons are too small #1025

katspaugh opened this issue Nov 1, 2022 · 3 comments · Fixed by #1031
Assignees
Labels
bug Something isn't working

Comments

@katspaugh
Copy link
Member

Some icons need fontSize="small" removed.

From @usame-algan's comment:

There are a few more icons that appear smaller than they used to be:

Address Book:
Screenshot 2022-11-01 at 16 14 34
Screenshot 2022-11-01 at 16 14 54

Owner Settings:
Screenshot 2022-11-01 at 16 15 14

Assets:
Screenshot 2022-11-01 at 16 20 29

There is some inconsistency with the icon viewboxes (some have a larger viewbox but overall smaller icon). Could this be related to how they are exported from Figma?

@katspaugh katspaugh added the bug Something isn't working label Nov 1, 2022
@katspaugh katspaugh moved this to Todo in Safe{Wallet} Nov 1, 2022
@iamacook iamacook moved this from Todo to In Progress in Safe{Wallet} Nov 2, 2022
@iamacook iamacook self-assigned this Nov 2, 2022
@iamacook
Copy link
Member

iamacook commented Nov 2, 2022

It seems this requires more than removing the prop. Some of the icon groups have varying padding sizes. We need to sync with design about this. cc @liliiaorlenko

@iamacook iamacook moved this from In Progress to Peer Review in Safe{Wallet} Nov 2, 2022
@liliiaorlenko
Copy link

It seems this requires more than removing the prop. Some of the icon groups have varying padding sizes. We need to sync with design about this. cc @liliiaorlenko

which icons should I fix exactly or all of them? maybe we can have short call

@iamacook
Copy link
Member

iamacook commented Nov 3, 2022

which icons should I fix exactly or all of them? maybe we can have short call

It's not a problem anymore. I managed to tackle it.

@iamacook iamacook moved this from Peer Review to Ready for QA in Safe{Wallet} Nov 4, 2022
Repository owner moved this from Ready for QA to Done in Safe{Wallet} Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants