Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't propose unsigned transactions #1261

Closed
katspaugh opened this issue Nov 28, 2022 · 2 comments · Fixed by #1298
Closed

Don't propose unsigned transactions #1261

katspaugh opened this issue Nov 28, 2022 · 2 comments · Fixed by #1298
Assignees

Comments

@katspaugh
Copy link
Member

katspaugh commented Nov 28, 2022

In a 1/X Safe, it's possible to create and immediately execute a transaction w/o signing it.

We're currently "proposing" such txns to the backend, where they are marked as untrusted until indexed.

@Uxio0 says we shouldn't do this. The ability to "propose" w/o signatures will be removed in the future on the backend.

@iamacook
Copy link
Member

We need to ensure this works well with smart contract wallet owners. Currently, if a Safe owns a Safe ("parent" vs. "nested"), the "parent" can queue the approval of a transaction of the "nested" Safe. As such, the "nested" Safe currently proposes a transaction without signatures.

@Uxio0
Copy link
Member

Uxio0 commented Nov 28, 2022

I think we never tested EIP1271 signatures for multisig transactions, but they are implemented 😉. Also in that case a delegate could be used to make things easier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants