Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI displays the wrong amount for spending limits #1310

Closed
usame-algan opened this issue Dec 5, 2022 · 0 comments · Fixed by #1346
Closed

UI displays the wrong amount for spending limits #1310

usame-algan opened this issue Dec 5, 2022 · 0 comments · Fixed by #1346
Assignees
Labels
bug Something isn't working major Major bug (to be solved in the next release)

Comments

@usame-algan
Copy link
Member

usame-algan commented Dec 5, 2022

Bug description

  • When creating a spending limit transaction, the UI displays the full amount instead of amount - spent.
  • The spacing inside the modal also looks a bit off

Steps to reproduce

  1. Open a Safe
  2. Create a new spending limit for your wallet
  3. Execute a spending limit transaction
  4. Observe that it displays the correct spent amount on the settings page
  5. Create a new spending limit transaction
  6. Observe that it still displays the original amount

Expected result

  • It should display the full amount - spent amount inside the modal
  • The area should have consistent top and bottom spacing

Obtained result

It displays the full amount inside the modal

Screenshots

In this case a transaction with 100 SAFE was already executed but it still displays 500 instead of 400. Going to the next step results in an error that is not caught in the UI.
Screenshot 2022-12-05 at 17 28 32

@usame-algan usame-algan added the bug Something isn't working label Dec 5, 2022
@katspaugh katspaugh moved this to New issues in Safe{Wallet} Dec 6, 2022
@iamacook iamacook added the major Major bug (to be solved in the next release) label Dec 6, 2022
@usame-algan usame-algan moved this from New issues to Todo in Safe{Wallet} Dec 12, 2022
@usame-algan usame-algan self-assigned this Dec 12, 2022
@usame-algan usame-algan moved this from Todo to Peer Review in Safe{Wallet} Dec 12, 2022
@usame-algan usame-algan moved this from Peer Review to Ready for QA in Safe{Wallet} Dec 13, 2022
@liliya-soroka liliya-soroka moved this from Ready for QA to QA in progress in Safe{Wallet} Dec 13, 2022
@liliya-soroka liliya-soroka moved this from QA in progress to Ready for QA in Safe{Wallet} Dec 13, 2022
@liliya-soroka liliya-soroka moved this from Ready for QA to QA in progress in Safe{Wallet} Dec 14, 2022
@liliya-soroka liliya-soroka moved this from QA in progress to QA done in Safe{Wallet} Dec 14, 2022
Repository owner moved this from QA done to Done in Safe{Wallet} Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working major Major bug (to be solved in the next release)
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants