Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EIP1271] Offchain signing UI tweaks #2019

Closed
katspaugh opened this issue May 22, 2023 · 0 comments · Fixed by #2372
Closed

[EIP1271] Offchain signing UI tweaks #2019

katspaugh opened this issue May 22, 2023 · 0 comments · Fixed by #2372
Assignees

Comments

@katspaugh
Copy link
Member

katspaugh commented May 22, 2023

  • Signatures from the same browser should be registered immedialy (currently there's a big lag even if it's from the connected wallet)
Screenshot 2023-05-22 at 13 01 42
  • To sign this message, you need to collect 2 owner signatures of your Safe. -> To sign this message, collect signatures from 2 owners of your Safe
  • Remove this message if the threshold is 1 (To sign this message, you need to collect 1 owner signatures of your Safe.)
  • Before closing the modal after the final signature comes in, add a 0.5-1s delay so that the Confirmations list is updated and the user has a chance to see it.
  • Hide this in a Message details accordion (not so useful info to an average person):
Screenshot 2023-05-22 at 13 04 36
@katspaugh katspaugh added the bug label May 22, 2023
@katspaugh katspaugh changed the title Offchain signing UI tweaks [EIP1271] Offchain signing UI tweaks May 24, 2023
@schmanu schmanu self-assigned this Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants